Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add krel announce subcommand #1173

Merged
merged 1 commit into from
May 24, 2020
Merged

Add krel announce subcommand #1173

merged 1 commit into from
May 24, 2020

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Mar 11, 2020 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

We now add a new krel subcommand which re-uses the already implemented
sendgrid code from the patch package. This code has been moved into a
new package mail, which will be now used by the patch announcer and
krel announce.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Demo:

> export SENDGRID_API_KEY=<KEY>
> go run ./cmd/krel announce -e [email protected] -n "Sascha Grunert" -t v1.18.0-beta.1
INFO Retrieving release announcement from Google Cloud Bucket
INFO Using announcement remote URL: https://dl.k8s.io/archive/anago-v1.18.0-beta.1/announcement.html
INFO Preparing mail sender
INFO Using "kubernetes-announce-test" google group as announcement target
INFO Sending mail

See the results here, I created that test mailing list manually for us:
https://groups.google.com/forum/#!topic/kubernetes-announce-test/gOK_8uJFfSU

Does this PR introduce a user-facing change?

- Added `krel announce` subcommand which can be used to announce any release to the `[email protected]` mailing list

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Mar 11, 2020
@justaugustus justaugustus mentioned this pull request May 21, 2020
Closed
@justaugustus
Copy link
Member

/hold
/assign

@saschagrunert -- Can you rebase this one?

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 21, 2020
cpanato
cpanato reviewed May 21, 2020
View reviewed changes
cmd/krel/cmd/announce.go Outdated Show resolved Hide resolved
@cpanato
Copy link
Member

cpanato commented May 21, 2020

Do we already have the kubernetes-announce-test group created?

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2020
@saschagrunert
Add krel announce subcommand
2af98b5 
We now add a new krel subcommand which re-uses the already implemented
sendgrid code from the `patch` package. This code has been moved into a
new package `mail`, which will be now used by the patch announcer and
`krel announce`.

Signed-off-by: Sascha Grunert <[email protected]>
@saschagrunert
Copy link
Member Author

Do we already have the kubernetes-announce-test group created?

Yes, there: https://groups.google.com/forum/#!forum/kubernetes-announce-test

Verified that it still works:

> go run ./cmd/krel announce -e [email protected] -n "Sascha Grunert" -t v1.18.3
INFO Retrieving release announcement from Google Cloud Bucket
INFO Using announcement remote URL: https://dl.k8s.io/archive/anago-v1.18.3/announcement.html
INFO Preparing mail sender
INFO Using Google Groups as announcement target: [kubernetes-announce-test]
INFO Sending mail

@saschagrunert
Copy link
Member Author

/retest

cpanato
cpanato approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2020
@justaugustus
Copy link
Member

Great work, @saschagrunert!
Let's merge this in and I'll leave a post-merge review for you to follow-up on when ready.

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2020
@k8s-ci-robot k8s-ci-robot merged commit 44172ed into kubernetes:master May 24, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 24, 2020
@saschagrunert saschagrunert deleted the krel-announce branch May 24, 2020 09:04
@saschagrunert saschagrunert mentioned this pull request May 29, 2020
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@hoegaarden hoegaarden Awaiting requested review from hoegaarden

Assignees

@justaugustus justaugustus

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
4 participants
@saschagrunert @justaugustus @cpanato @k8s-ci-robot